refactor: update sbt-by-example #1153
Conversation
| @@ -211,35 +226,34 @@ sbt:Hello> ~testQuick | |||
|
|
|||
| ### Write a test | |||
|
|
|||
| Leaving the previous command running, create a file named `src/test/scala/HelloSpec.scala` | |||
| Leaving the previous command running, create a file named `src/test/scala/example/HelloSpec.scala` | |||
There was a problem hiding this comment.
Tiny change, but I noticed it while going through this. Since we had the user create src/main/scala/example/ I thought it appropriate to also do the same for the test, which is more than likely going to be followed on their teams anyways.
|
Running the I don't see any errors though when it runs so I don't fully get what is failing here or why this is marked EDIT: Ah after seeing c170298 I'm assuming I can just rename this back to |
I love this guide. I always recommend it to new people getting starting with sbt. The last couple times I did however they always came back to me ab out certain things not working anymore, mainly the console examples. I decided to just go through the whole thing myself and update all of the examples using a more modern sbt version and updating the output to match. There is also a couple other choices that I made while updating things like: - Changing the weather site we use as an example since it no longer is active - Changing the libraries being used from gigahorse to sttp and Play JSON to uJson. I didn't do this _just because_ but rather to more align with the libraries that are being used by the scala toolkit. Hopefully people will be a bit more familiar with these as I don't assume a newcomer to Scala will be using gigahorse or really Play JSON _unless_ they are using Play!. If this isn't ok, let me know and I can try to recreate it using the old libraries, but I think these examples are clearer.
|
Thanks for doing this, @ckipp01! |
|
Thanks for the contribution @ckipp01! I'm on vacation and I haven't had chance to look into the details yet. |
ckipp01
force-pushed
the
sbt-by-example
branch
from
e5a9379
to
feb7c04
Compare
ckipp01
force-pushed
the
sbt-by-example
branch
from
feb7c04
to
9e4a8ab
Compare
|
Alright, so I switched out the usages of explicit dependencies to instead use the |
I love this guide. I always recommend it to new people getting starting with sbt. The last couple times I did however they always came back to me ab out certain things not working anymore, mainly the console examples. I decided to just go through the whole thing myself and update all of the examples using a more modern sbt version and updating the output to match. There is also a couple other choices that I made while updating things like: